odbc_result::as_double(date) should use UTC timezone #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
It's because the user timezone info on
date
is meaningless. Converting to the user timezone then extracting the date part will leading to one-day leap if the timezone is UTC+n, like Asia/Shanghai, or "Europe/Berlin".This PR will address this issue.
Example
(Before this PR, the result is "2018-12-31")
Created on 2019-08-26 by the reprex package (v0.2.1)