Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EFI_RNG_PROTOCOL #36

Closed
wants to merge 1 commit into from
Closed

Add EFI_RNG_PROTOCOL #36

wants to merge 1 commit into from

Conversation

Ayush1325
Copy link
Contributor

Signed-off-by: Ayush Singh ayushsingh1325@gmail.com

Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Copy link
Member

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments inline. Again, I fixed them myself in a followup. If anything is unclear, let me know!

Thanks a lot! Merged manually now.

&[0x70, 0xbf, 0xb6, 0x29, 0x3f, 0x96],
);
pub const ALGORITHM_SP800_90_HMAC_256: Algorithm = crate::base::Guid::from_fields(
0xc5159b43,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0xc5159b43 -> 0xc5149b43

0xc8,
&[0x0b, 0x6a, 0x32, 0x4f, 0x55, 0x46],
);
pub const ALGORITHM_X9_31_AES: Algorithm = crate::base::Guid::from_fields(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec includes the _GUID suffix for all those constants. I added them to stay closer to the spec.

0xc8,
&[0x20, 0xcf, 0xd8, 0x88, 0x20, 0xc9],
);
pub const ALGORITHM_RAW: Algorithm = crate::base::Guid::from_fields(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this is not suffixed _GUID in the spec, nor does tianocore suffix it, so I kept it as it is.

#[repr(C)]
pub struct Protocol {
get_info: GetInfo,
get_rng: GetRNG,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefixed those with Protocol* again.

@dvdhrm dvdhrm closed this Jul 6, 2022
@Ayush1325 Ayush1325 deleted the random branch July 6, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants