Add TCP4 and IP4 protocols #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
4 tasks
dvdhrm
approved these changes
Jul 11, 2022
Comment on lines
-95
to
+96
| r#type: u8, | ||
| code: u8, | ||
| pub r#type: u8, | ||
| pub code: u8, |
There was a problem hiding this comment.
I pulled this out into its own commit.
Comment on lines
+117
to
+118
| pub header_length: u8, | ||
| pub version: u8, |
There was a problem hiding this comment.
These are bitfields in the spec (4-bits each). Since rust has no stable representation of bitfields, I merged them so far and simply concatenated the names. So in this case it would be:
Suggested change
| pub header_length: u8, | |
| pub version: u8, | |
| pub header_length_version: u8, |
| #[repr(C)] | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct TransmitData { | ||
| pub destination_address: *mut crate::base::Ipv6Address, |
There was a problem hiding this comment.
Suggested change
| pub destination_address: *mut crate::base::Ipv6Address, | |
| pub destination_address: crate::base::Ipv4Address, |
No pointer, and 4 instead of 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ayush Singh ayushsingh1325@gmail.com