Add ICMP Error Definitions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
dvdhrm
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
I think we can drop the annotation that tells where they come from. Those are pretty random places in the spec, and it is easy to find those definitions via a search. They are also often just treated as global definitions without specific protocol requirements, and their names reflect this.
Btw., I also think we should keep them ordered by their error-number, to avoid confusion.
I will do that in a follow-up myself. Thanks for picking those definitions up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments about TCP and ICMP come from how they are defined under
MdePkg/Include/Uefi/UefiBaseType.hSigned-off-by: Ayush Singh ayushsingh1325@gmail.com