Implement Default for tcp4::ConfigData #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing unint data to `EFI_TCP4_PROTOCOL.GetModeData()` causes UB. Passing `MaybeUnint::zeroed()` works fine though. Signed-off-by: Ayush <ayushsingh1325@gmail.com>
dvdhrm
approved these changes
Aug 18, 2022
Comment on lines
457
to
461
| #[repr(C)] | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq, Default)] | ||
| pub struct Ipv4Address { | ||
| pub addr: [u8; 4], | ||
| } |
There was a problem hiding this comment.
std::net::Ipv4Addr does not implement Default. Do you happen to know why? I think INADDR_ANY / all-zero is a suitable default, so I am fine with this. I just wondered why std does not have this.
There was a problem hiding this comment.
I just noticed that now as well. I would have expected the default to be UNSPECIFIED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing unint data to
EFI_TCP4_PROTOCOL.GetModeData()causes UB.Passing
MaybeUnint::zeroed()works fine though.Not sure if this is the intended behavior or a bug in OVMF.
Signed-off-by: Ayush ayushsingh1325@gmail.com