Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDP Protocols #52

Closed
wants to merge 2 commits into from
Closed

Add UDP Protocols #52

wants to merge 2 commits into from

Conversation

Ayush1325
Copy link
Contributor

Part of #35 .

@Ayush1325
Add UDP4 Protocol
7ea3bb7 
Part of issue: r-efi#35

Signed-off-by: Ayush <ayushsingh1325@gmail.com>
@Ayush1325
Add UDP6 Protocol
f447d5f 
Part of issue: r-efi#35

Signed-off-by: Ayush <ayushsingh1325@gmail.com>
@Ayush1325
Copy link
Contributor Author

Hi @dvdhrm , can you rerun the CI now that rust-lang/rust#101071 has been merged? I think it should be fixed now.

dvdhrm
dvdhrm approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The udp6 protocol has a bunch of IPv4Address instead of IPv6Address typos. I fixed those. Everything else looks good! Merged! Thanks a lot.

@dvdhrm dvdhrm closed this Sep 6, 2022
@Ayush1325 Ayush1325 deleted the udp-protocol branch October 11, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdhrm dvdhrm dvdhrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ayush1325 @dvdhrm