Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fedora #12

Merged
merged 1 commit into from Sep 16, 2016
Merged

update fedora #12

merged 1 commit into from Sep 16, 2016

Conversation

@jeroen
Copy link
Member

jeroen commented Sep 16, 2016

Fedora 22 is super old and deprecated. 24 is stable now.

screen shot 2016-09-16 at 1 12 22 pm

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 16, 2016

Good point, thanks!

Hmmm. I am not sure about latest, though. Ideally we would use the same version as CRAN, i.e. https://cran.r-project.org/web/checks/check_flavors.html
But then I won't notice when they update and end up with an older version, like now.... so yes, we can go with latest.

I'll push a new Docker build for the builders and make sure it works. And I'll also need to update the metadata for the platforms. We really should have this in a central DB.....

@gaborcsardi gaborcsardi merged commit 9c1c203 into r-hub:master Sep 16, 2016
@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 16, 2016

It will take a bit longer, sorry. I'll try to add it soon. But maybe the builds will just work by themselves.

@jeroen
Copy link
Member Author

jeroen commented Sep 16, 2016

No rush, just noticed it when check a pkg and thought it should be fixed.

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

I am having a hard time installing clang 3.9.0 on Fedora 24. Do you know a place where it is available? I don't really want to build it....

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

Why not just use stock clang 3.8.0 ?

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

BEcause CRAN has 3.9.0, so that would be optimal....

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

Looks like I can easily have clang 3.9.0 on Fedora 23 or clang 3.8.0 on Fedora 24. Hmmmm.

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

CRAN has custom builds of everything, but I think it's fine to stick with stock compilers here. clang 3.9.0 will probably soon be available on Fedora 25...

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

OK, let me try a bit harder before I give up....

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

OK, but don't waste too much valuable time on trying to keep up with whatever cran comes up with :) I think if we can build with stock R/compilers on current Fedora/Debian/CentOS, that covers like 98% of the use cases.

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

But if you really want, note that more important than clang/gcc is which c++ lib is used. Clang can either use gnu libstdc++ (default on fedora) or libcxx (part of llvm) which is a huge difference.

If you use libcxx note that this can result in linking problems to system c++ libraries that were compiled with gcc (libv8, libmagick++, etc).

We had a long discussion about it with Kurt and JJ and it's very complex. See also:

https://bugzilla.redhat.com/show_bug.cgi?id=1332306
https://bugzilla.redhat.com/show_bug.cgi?id=1332307

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

I see. Thanks!

I am not sure what CRAN is using, actually: http://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang

What is libc++ here?

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

libc++ means llvm's libcxx. That means you need to recompile every C++ library on the system with libc++ (which BDR does).

@jeroen
Copy link
Member Author

jeroen commented Sep 22, 2016

I'm fowarding you an email from Kurt which I think is still current.

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 22, 2016

OMG. OK, I guess I won't do this.

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 26, 2016

OK, finally this is deployed. I had to fix the locales, which are apparently messed up in the fedora:latest docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.