New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass flags to R CMD check #4

Closed
hadley opened this Issue Sep 8, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@hadley
Collaborator

hadley commented Sep 8, 2016

e.g. --use-valgrind

@gaborcsardi gaborcsardi modified the milestone: CRAN submission Sep 13, 2016

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Sep 13, 2016

Member
  • Command line arguments, like --use-valgrind
  • environment variables to set for the build.
Member

gaborcsardi commented Sep 13, 2016

  • Command line arguments, like --use-valgrind
  • environment variables to set for the build.
@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Sep 26, 2016

Member

--use-valgrind is supported in e34f873. Maybe it would be simpler just to allow arbitrary arguments. The HTTP API itself works with arguments.

Member

gaborcsardi commented Sep 26, 2016

--use-valgrind is supported in e34f873. Maybe it would be simpler just to allow arbitrary arguments. The HTTP API itself works with arguments.

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Sep 27, 2016

Member

Environment variables work as well. I just added arbitrary arguments as well, for Linux.

Windows is still a TODO.

Member

gaborcsardi commented Sep 27, 2016

Environment variables work as well. I just added arbitrary arguments as well, for Linux.

Windows is still a TODO.

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Oct 3, 2016

Member

OK, implemented for windows as well.

Member

gaborcsardi commented Oct 3, 2016

OK, implemented for windows as well.

@gaborcsardi gaborcsardi closed this Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment