New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching should always be case insensitive #5

Closed
jeroen opened this Issue Oct 2, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@jeroen
Member

jeroen commented Oct 2, 2017

A string like openssl should also match OpenSSL or Openssl or openSSL. I don't see any downside to this, I don't think there are libraries with identical names but different case.

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Oct 2, 2017

Member

FWIW, openssl was only included as OpenSSL. :)

Member

gaborcsardi commented Oct 2, 2017

FWIW, openssl was only included as OpenSSL. :)

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Oct 2, 2017

Member

But it is case insensitive now: https://sysreqs.r-hub.io/map/openssl

[{
  "openssl": {
      "sysreqs": "OpenSSL",
      "platforms": {
          "DEB": "libssl-dev",
          "OSX/brew": "openssl@1.1",
          "RPM": "openssl-devel"
      }
   }
}]
Member

gaborcsardi commented Oct 2, 2017

But it is case insensitive now: https://sysreqs.r-hub.io/map/openssl

[{
  "openssl": {
      "sysreqs": "OpenSSL",
      "platforms": {
          "DEB": "libssl-dev",
          "OSX/brew": "openssl@1.1",
          "RPM": "openssl-devel"
      }
   }
}]
@jeroen

This comment has been minimized.

Show comment
Hide comment
@jeroen

jeroen Oct 2, 2017

Member

Great! Now I can remove some regexes from the DB and just use strings.

Member

jeroen commented Oct 2, 2017

Great! Now I can remove some regexes from the DB and just use strings.

@gaborcsardi

This comment has been minimized.

Show comment
Hide comment
@gaborcsardi

gaborcsardi Oct 2, 2017

Member

I would not worry, regexes are just as good.

Member

gaborcsardi commented Oct 2, 2017

I would not worry, regexes are just as good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment