Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in setup step even though it seems to succeed #116

Closed
Enchufa2 opened this issue Jun 6, 2020 · 18 comments
Closed

Error in setup step even though it seems to succeed #116

Enchufa2 opened this issue Jun 6, 2020 · 18 comments
Labels
bug

Comments

@Enchufa2
Copy link

@Enchufa2 Enchufa2 commented Jun 6, 2020

I have two workflows: one to check the package that is triggered for every push, and another one to build the pkgdown site when a new release is published.

Any idea what's the issue here?

@Enchufa2 Enchufa2 added the bug label Jun 6, 2020
@trangdata
Copy link

@trangdata trangdata commented Jun 6, 2020

r-lib/actions/setup-r@master is also failing for me. Worked yesterday. I wonder if this is related to the r 4.0.1 release?

@Enchufa2
Copy link
Author

@Enchufa2 Enchufa2 commented Jun 6, 2020

Good catch! That's the cause, because I just tried with R 3.6.3 and it works: https://github.com/r-quantities/quantities/runs/745325070?check_suite_focus=true

@CorradoLanera
Copy link

@CorradoLanera CorradoLanera commented Jun 6, 2020

same issue here w/ lint, pkgdown, and test-coverage (it works for R-CMD-check)

@jonkeane
Copy link

@jonkeane jonkeane commented Jun 6, 2020

I think that at least part of the problem is that the JSON at https://rversions.r-pkg.org/r-versions is malformed (note that the comma on line 5 should be one line up immediately following the closing brace and not immediately following the open brace). This results in the version map being empty and no matching R version being installed.

...
    {
	"version": "4.0.0",
	"date": "2020-04-24T07:05:34.612Z"
    }
    {,
	"version": "4.0.1",
	"date": "2020-06-06T07:05:16.469439Z"
    }

@jonkeane
Copy link

@jonkeane jonkeane commented Jun 7, 2020

The fix for the r-versions.json was merged and is available now, and my builds are back to running again.

@albersonmiranda
Copy link

@albersonmiranda albersonmiranda commented Jun 7, 2020

r-lib/actions/setup-r@master still failling for me.

@yutannihilation
Copy link
Contributor

@yutannihilation yutannihilation commented Jun 7, 2020

I'm also seeing the failure on some runners, while some other ones are running fine. My guess is that the response of https://rversions.r-pkg.org/r-versions is cached somehow (CDN?) and the change doesn't always propagate immediately.

@jonkeane
Copy link

@jonkeane jonkeane commented Jun 7, 2020

Is it failing for all versions or for a specific one?

I also noticed that although 4.0.1 has been released, it doesn't look like the binary is available for macOS yet. It looks like by default if you specify r version 4.0 it will try and pull the laters (but not be able to because the 4.0.1 binary isn't up yet). I worked around this for now by specifying 4.0.0 and that worked fine for me:

https://github.com/jonkeane/dittodb/blob/pkgdown-cleanup/.github/workflows/check-mac.yaml#L16 and https://github.com/jonkeane/dittodb/actions/runs/127718220

@markromanmiller
Copy link

@markromanmiller markromanmiller commented Jun 7, 2020

Specifying the patch also worked for me. Are the macOS binaries likely to be released within a few days?

@ha0ye
Copy link

@ha0ye ha0ye commented Jun 7, 2020

My guess is that the response of https://rversions.r-pkg.org/r-versions is cached somehow (CDN?) and the change doesn't always propagate immediately.

I had the same issue yesterday, even after seeing this comment; but re-running the job just now succeeded, so good sign for the propagation of the fix?

@CorradoLanera
Copy link

@CorradoLanera CorradoLanera commented Jun 7, 2020

Re-run everything now, all fixed from my side. thanks!

@albersonmiranda
Copy link

@albersonmiranda albersonmiranda commented Jun 9, 2020

Is it safe now to remove R 4.0.0 version specification?

@jimhester
Copy link
Member

@jimhester jimhester commented Jun 9, 2020

the problem was there is a OS specific r,versions endpoint for macOS (https://rversions.r-pkg.org/r-release-macos), which is what version: release uses. But if you specify version: 4.0 in the action we query (https://rversions.r-pkg.org/r-versions) for the versions, and that does not have an OS specific endpoint. Plus as mentioned the macOS binary for 4.0.1 lagged the other OSs, which is what caused the failure.

The binary for 4.0.1 exists now so all cases should work as normal.

@wlandau
Copy link

@wlandau wlandau commented Jul 21, 2020

In the second one, the setup step fails even though it seems that it succeeded according to the log: https://github.com/r-quantities/quantities/runs/745114620?check_suite_focus=true

I am just now running into a similar issue with R-devel on Mac OS: https://github.com/wlandau/targets/runs/892584841. The analogous Mac OS build for R-release succeeds: https://github.com/wlandau/targets/runs/892584830.

@wlandau
Copy link

@wlandau wlandau commented Jul 21, 2020

@jimhester, you mentioned https://rversions.r-pkg.org/r-release-macos. Is there supposed to be an analogous https://rversions.r-pkg.org/r-devel-macos? Doesn't seem to exist at the moment.

@sckott
Copy link

@sckott sckott commented Jul 22, 2020

+1 same problem with r-devel macos

@vissarion
Copy link

@vissarion vissarion commented Jul 29, 2020

+1 same problem here for macos-latest and r-devel.
It is OK with macos-latest and r-release
https://github.com/GeomScale/volume_approximation/actions/runs/184043422
@jimhester should we open a new issue?

@jimhester
Copy link
Member

@jimhester jimhester commented Jul 29, 2020

#140 is tracking the lack of R-devel on macOS. In short the daily devel binaries previously available on https://mac.r-project.org have been removed with no explanation, we can't do anything unless they are restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

No branches or pull requests