Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Render README" example -- should it install the package? #52

Closed
jennybc opened this issue Feb 21, 2020 · 1 comment
Closed

"Render README" example -- should it install the package? #52

jennybc opened this issue Feb 21, 2020 · 1 comment
Labels
feature a feature request or enhancement

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Feb 21, 2020

I'm surprised this example does not have a step where it installs the package:

https://github.com/r-lib/actions/tree/master/examples#render-readme

@jennybc jennybc added bug an unexpected problem or unintended behavior and removed bug an unexpected problem or unintended behavior labels Feb 21, 2020
@jimhester
Copy link
Member

@jimhester jimhester commented Feb 29, 2020

I guess for this particular repo we don't have to install the package, but I agree generally it would make sense to do so, so we should add this.

@jimhester jimhester added the feature a feature request or enhancement label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants