New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on R-devel? #37

Closed
gaborcsardi opened this Issue Feb 10, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@gaborcsardi
Copy link
Member

gaborcsardi commented Feb 10, 2018

From CRAN:

Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_callr.html>.

Please correct before 2018-02-24 to safely retain your package on CRAN.

Best,
-k
@gaborcsardi

This comment has been minimized.

Copy link
Member Author

gaborcsardi commented Feb 10, 2018

Failures are the same on all platforms:

Version: 2.0.1 
Check: tests 
Result: ERROR 
     Running ‘testthat.R’ [12s/38s]
    Running the tests in ‘tests/testthat.R’ failed.
    Complete output:
     > library(testthat)
     > library(callr)
     > 
     > Sys.unsetenv("R_TESTS")
     > test_check("callr")
     ── 1. Failure: error is propagated (@test-error.R#5) ──────────────────────────
     `r(function() 1 + "A")` threw an error with unexpected message.
     Expected match: "non-numeric argument to binary operator"
     Actual message: "child process crashed or was killed"
     
     ── 2. Failure: error stack is passed (@test-error.R#37) ───────────────────────
     inherits(err, "callr_error") isn't true.
     
     ── 3. Failure: error stack is passed (@test-error.R#38) ───────────────────────
     length(err$stack) not equal to 3.
     1/1 mismatches
     [1] 0 - 3 == -3
     
     ── 4. Failure: r_bg can get the error back (@test-r-bg.R#26) ──────────────────
     `x$get_result()` threw an error with unexpected message.
     Expected match: "non-numeric argument to binary operator"
     Actual message: "child process crashed or was killed"
     
     ══ testthat results ═══════════════════════════════════════════════════════════
     OK: 472 SKIPPED: 7 FAILED: 4
     1. Failure: error is propagated (@test-error.R#5) 
     2. Failure: error stack is passed (@test-error.R#37) 
     3. Failure: error stack is passed (@test-error.R#38) 
     4. Failure: r_bg can get the error back (@test-r-bg.R#26) 
     
     Error: testthat unit tests failed
     Execution halted 
Flavor: r-devel-linux-x86_64-debian-gcc

gaborcsardi added a commit that referenced this issue Feb 10, 2018

Fix error handling issues on R-devel
They are caused by a behavior change in saveRDS.
It always used to create the output file, but now
it does not do that any more, if the object to write
out cannot be successfully created.
See wch/r-source@9245829

Closes #37

gaborcsardi added a commit that referenced this issue Feb 10, 2018

Fix error handling issues on R-devel
They are caused by a behavior change in saveRDS.
It always used to create the output file, but now
it does not do that any more, if the object to write
out cannot be successfully created.
See wch/r-source@9245829

Closes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment