New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supervise option to r_bg and rcmd_bg #45

Merged
merged 2 commits into from Mar 22, 2018

Conversation

Projects
None yet
3 participants
@wch
Copy link
Member

wch commented Mar 22, 2018

This adds the supervise option to r_bg and rcmd_bg.

wch added some commits Mar 22, 2018

@gaborcsardi

This comment has been minimized.

Copy link
Member

gaborcsardi commented Mar 22, 2018

Look great! I'll wait for the version bump and the CIs. Btw. could you please add it to the NEWS? Thanks.

@wch

This comment has been minimized.

Copy link
Member Author

wch commented Mar 22, 2018

NEWS update is already done!

@gaborcsardi

This comment has been minimized.

Copy link
Member

gaborcsardi commented Mar 22, 2018

oh, you did the NEWS, ok, great. I'll just wait for the CIs, and then merge.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #45 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   76.74%   76.76%   +0.02%     
==========================================
  Files          43       43              
  Lines        2812     2815       +3     
==========================================
+ Hits         2158     2161       +3     
  Misses        654      654
Impacted Files Coverage Δ
R/rcmd-bg.R 100% <ø> (ø) ⬆️
R/eval-bg.R 100% <ø> (ø) ⬆️
R/r-process.R 100% <100%> (ø) ⬆️
R/options.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c451d...b0f91c0. Read the comment docs.

@gaborcsardi gaborcsardi merged commit f981a0b into r-lib:master Mar 22, 2018

4 checks passed

codecov/patch 100% of diff hit (target 76.74%)
Details
codecov/project 76.76% (+0.02%) compared to 01c451d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment