New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite libpath handling and passing #75

Merged
merged 5 commits into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@gaborcsardi
Copy link
Member

gaborcsardi commented Aug 16, 2018

In a more disciplined way. See #73.

Seemingly this also fixes #55.

Hopefully also fixes #68.

gaborcsardi added some commits Aug 16, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #75 into master will increase coverage by 0.94%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #75      +/-   ##
=========================================
+ Coverage   82.66%   83.6%   +0.94%     
=========================================
  Files          16      16              
  Lines         721     738      +17     
=========================================
+ Hits          596     617      +21     
+ Misses        125     121       -4
Impacted Files Coverage Δ
R/eval-bg.R 100% <ø> (ø) ⬆️
R/eval.R 100% <ø> (ø) ⬆️
R/presets.R 100% <ø> (ø) ⬆️
R/rcmd.R 92.3% <ø> (ø) ⬆️
R/r-session.R 67.12% <100%> (+1.25%) ⬆️
R/options.R 100% <100%> (ø) ⬆️
R/setup.R 95.04% <95.12%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea610e...2c9da98. Read the comment docs.

Fix test cases on Windows
Removed the connection-close test case,
because it does not seem to work on Windows.

@gaborcsardi gaborcsardi merged commit 01fb312 into master Aug 16, 2018

6 checks passed

codecov/patch 95.34% of diff hit (target 82.66%)
Details
codecov/project 83.6% (+0.94%) compared to 0ea610e
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

krlmlr added a commit to ropenscilabs/tic that referenced this pull request Sep 1, 2018

Revert "Switch to regular dev version, r-lib/callr#55 merged now"
This reverts commit 1bcf0ff.

Need to investigate, r-lib/callr#75 breaks knitting for all R versions.

@krlmlr krlmlr referenced this pull request Sep 1, 2018

Closed

Can't use rcmdcheck() #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment