New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libpath propagation for .Renviron & system() #84

Merged
merged 5 commits into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@gaborcsardi
Copy link
Member

gaborcsardi commented Oct 24, 2018

Closes #83. See details there.

@gaborcsardi gaborcsardi requested a review from jimhester Oct 24, 2018

@gaborcsardi gaborcsardi force-pushed the fix/libpath-renviron-system branch from aa08111 to c663c63 Oct 24, 2018

@gaborcsardi gaborcsardi force-pushed the fix/libpath-renviron-system branch from c663c63 to 5b669c6 Oct 24, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #84 into master will decrease coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   84.05%   83.62%   -0.44%     
==========================================
  Files          17       17              
  Lines         803      812       +9     
==========================================
+ Hits          675      679       +4     
- Misses        128      133       +5
Impacted Files Coverage Δ
R/setup.R 93.04% <100%> (-2.24%) ⬇️
R/r-session.R 67% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ea2b6...7e45bfc. Read the comment docs.

@gaborcsardi

This comment has been minimized.

Copy link
Member Author

gaborcsardi commented Oct 24, 2018

@jimhester I think this is good now.

gaborcsardi added some commits Oct 24, 2018

Fix system() libpath test on Windows
Forward slash vs backward slash...

@gaborcsardi gaborcsardi force-pushed the fix/libpath-renviron-system branch from 6ff82ce to 7e45bfc Oct 24, 2018

gaborcsardi added a commit to r-lib/revdepcheck that referenced this pull request Oct 24, 2018

Fix library path
We need to set `R_ENVIRON_USER` to an existing file,
otherwise R does not use it. We also need to set R_LIBS
to empty, because otherwise R will pick it up.

Closes #160.

Note that this is also fixed in callr, once
r-lib/callr#84 is merged.
The callr fix is not needed for this revdepcheck fix.
@gaborcsardi

This comment has been minimized.

Copy link
Member Author

gaborcsardi commented Oct 25, 2018

Thanks!

@gaborcsardi gaborcsardi merged commit dab02eb into master Oct 25, 2018

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment