`ansi_strtrim()` falls over if there's an `NA`

[jennybc]

It feels like an NA should just propagate here. I encountered this while implementing a format method (well, technically, a pillar_shaft() method).

x <- month.name
cli::ansi_strtrim(x, width = 3)
#> <ansi_string>
#> [1] Ja… 
#> [2] Fe… 
#> [3] Ma… 
#> [4] Ap… 
#> [5] Ma  
#> [6] Ju… 
#> [7] Ju… 
#> [8] Au… 
#> [9] Se… 
#> [10] Oc…
#> [11] No…
#> [12] De…

x[2] <- NA
cli::ansi_strtrim(x, width = 3)
#> Error in ansi_substr(xt[bad], 1, ansi_nchar(xt[bad]) - 1L): non-numeric substring arguments not supported

^{Created on 2021-07-06 by the reprex package (v2.0.0.9000)}

[gaborcsardi]

Closed in 910f92d