Favour new RStudio env vars over existing heuristics

[hadley]

rstudio/rstudio#11024

Obviously will want to keep heuristics for some time (probably several years), until this version of RStudio is in widespread usage.

[hadley]

I think this should fix the problem with the "Run Tests" button in RStudio; currently when it's run cli::is_dynamic_tty() is FALSE so we get a sub-optimal display.

[gaborcsardi]

Maybe. OTOH the current detection should also detect the build pane correctly, I believe, so maybe this is not the reason?

[romainfrancois]

related to rstudio/rstudio#11281

[DavisVaughan]

A few concrete differences between Run Tests on a single file and CMD+SHIFT+T that hopefully can be resolved:

• Run Tests doesn't have color
• Run Tests links to files, like test-vec-case-when.R, but doesn't link snapshot_accept()

I'm on RStudio 2022.06.0-daily+385

[hadley]

If I install r-lib/rlang#1404 and devtools::document(), I don't see colour working in the build pane either, so I think the current heuristics fail for more than just "Test file".

[romainfrancois]

For the links, I think it's related to the cli.num_colors option used in:

cli/R/ansi-hyperlink.R

Line 60 in 23ab07e

opt <- as.integer(getOption("cli.num_colors", NULL))[1]

at least this is what makes it return FALSE

[romainfrancois]

Maybe ? related to local_reproducible_output(.env = )

https://github.com/r-lib/testthat/blob/0f24eae7bd2cd7d0fbe5a5492636731d66d0dd26/R/local.R#L106

[gaborcsardi]

@hadley The "Run tests" button wasn't detected with the old methods, I fixed that as well in #471. I probably only looked at the commands in the Build menu....

@DavisVaughan What does CMD+SHIFT+T run?

[DavisVaughan]

@gaborcsardi It runs devtools::test() in the Build pane (which I am fairly certain is in a new R session)