Merged
Conversation
This was referenced Jan 27, 2023
Contributor
Author
|
@gaborcsardi Friendly reminder to have a look at this. 🙂 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #568.
Some snapshot tests failed (i.e. produced different output). I think most of them currently also fail on the
mainbranch, i.e. have nothing to do with this PR.But I noticed one particular test that might actually be caused by this PR:I'm not familiar enough with cli to understand why that is, so I'll leave it to you. Hope that's fine. 🙂I've updatedinline_collapse()which relies onansi_collapse(). Should be fine now.