From 7297ce4d6c20cc974e5f510a9419b70d72433b11 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Wed, 24 Feb 2021 16:01:57 -0500 Subject: [PATCH 01/12] Add CRAN comments --- .Rbuildignore | 1 + cran-comments.md | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 cran-comments.md diff --git a/.Rbuildignore b/.Rbuildignore index 626c19f1..693ec428 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -10,3 +10,4 @@ ^docs$ ^pkgdown$ ^vignettes/articles$ +^cran-comments\.md$ diff --git a/cran-comments.md b/cran-comments.md new file mode 100644 index 00000000..971a6c87 --- /dev/null +++ b/cran-comments.md @@ -0,0 +1,20 @@ +## Test environments +* local R installation, R 4.0.0 +* ubuntu 16.04 (on travis-ci), R 4.0.0 +* win-builder (devel) + +## R CMD check results + +0 errors | 0 warnings | 2 notes + +* This is a new release. + +* checking installed package size ... NOTE + installed size is 8.6Mb + sub-directories of 1Mb or more: + libs 5.4Mb + tzdata 1.3Mb + +## 0.1.0 Submission + +This is the first release of clock. clock is above the recommended 5.0Mb package size because it contains a large amount of compiled code. From 4e62194607ca176ee105becec79a90bbd64960a0 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Tue, 2 Mar 2021 14:04:03 -0500 Subject: [PATCH 02/12] Tweak CRAN comments --- cran-comments.md | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 971a6c87..6f8914f1 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,8 +1,3 @@ -## Test environments -* local R installation, R 4.0.0 -* ubuntu 16.04 (on travis-ci), R 4.0.0 -* win-builder (devel) - ## R CMD check results 0 errors | 0 warnings | 2 notes @@ -17,4 +12,4 @@ ## 0.1.0 Submission -This is the first release of clock. clock is above the recommended 5.0Mb package size because it contains a large amount of compiled code. +This is the first release of clock. From f498a71cc4a9c343d163d7ff963ea896bb449dab Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Thu, 18 Mar 2021 12:29:50 -0400 Subject: [PATCH 03/12] Try mentioning that I have no references in the cran comments --- cran-comments.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cran-comments.md b/cran-comments.md index 6f8914f1..d097e221 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -12,4 +12,4 @@ ## 0.1.0 Submission -This is the first release of clock. +This is the first release of clock. There are no references that I would like to include with the package. From 5323b5d1ff5694a713d667680a9d9e852e9d8bd5 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Thu, 25 Mar 2021 16:23:24 -0400 Subject: [PATCH 04/12] Update installation instructions in the README --- README.Rmd | 8 +++++++- README.md | 9 ++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/README.Rmd b/README.Rmd index 97362812..b8919a52 100644 --- a/README.Rmd +++ b/README.Rmd @@ -44,7 +44,13 @@ There are four key classes in clock, inspired by the design of the C++ date and ## Installation -You can install the development version of clock with: +Install the released version from [CRAN](https://CRAN.R-project.org) with: + +``` r +install.packages("clock") +``` + +Install the development version from [GitHub](https://github.com/) with: ``` r # install.packages("remotes") diff --git a/README.md b/README.md index 7b4f3038..4da71685 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,14 @@ you get a complete date time library. ## Installation -You can install the development version of clock with: +Install the released version from [CRAN](https://CRAN.R-project.org) +with: + +``` r +install.packages("clock") +``` + +Install the development version from [GitHub](https://github.com/) with: ``` r # install.packages("remotes") From 790ad2d73d59587b0b7d98ca02f71701f478517b Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 08:25:57 -0400 Subject: [PATCH 05/12] Include a comment about the installed size --- cran-comments.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cran-comments.md b/cran-comments.md index d097e221..70c6309d 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -12,4 +12,4 @@ ## 0.1.0 Submission -This is the first release of clock. There are no references that I would like to include with the package. +This is the first release of clock. There are no references that I would like to include with the package. The installed size of clock may be large on some platforms due to the large amount of templated C++ code included with the package. From c1157104fbf48022a1c6f07c8ac0fd37470ad62f Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 08:42:38 -0400 Subject: [PATCH 06/12] use_tidy_description() --- DESCRIPTION | 13 ++++++------- man/clock-package.Rd | 13 ++++++------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index c55fc43e..868fd255 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -12,13 +12,12 @@ Authors@R: comment = "Author of the included date library"), person(given = "RStudio", role = c("cph", "fnd"))) -Description: Provides a comprehensive library for date-time - manipulations using a new family of orthogonal date-time classes - (durations, time points, zoned-times, and calendars) that partition - responsibilities so that the complexities of time zones are only - considered when they are really needed. Capabilities include: - date-time parsing, formatting, arithmetic, extraction and updating of - components, and rounding. +Description: Provides a comprehensive library for date-time manipulations + using a new family of orthogonal date-time classes (durations, time + points, zoned-times, and calendars) that partition responsibilities so + that the complexities of time zones are only considered when they are + really needed. Capabilities include: date-time parsing, formatting, + arithmetic, extraction and updating of components, and rounding. License: MIT + file LICENSE URL: https://github.com/r-lib/clock BugReports: https://github.com/r-lib/clock/issues diff --git a/man/clock-package.Rd b/man/clock-package.Rd index d5372c33..1d0c03e5 100644 --- a/man/clock-package.Rd +++ b/man/clock-package.Rd @@ -8,13 +8,12 @@ \description{ \if{html}{\figure{logo.png}{options: align='right' alt='logo' width='120'}} -Provides a comprehensive library for date-time - manipulations using a new family of orthogonal date-time classes - (durations, time points, zoned-times, and calendars) that partition - responsibilities so that the complexities of time zones are only - considered when they are really needed. Capabilities include: - date-time parsing, formatting, arithmetic, extraction and updating of - components, and rounding. +Provides a comprehensive library for date-time manipulations + using a new family of orthogonal date-time classes (durations, time + points, zoned-times, and calendars) that partition responsibilities so + that the complexities of time zones are only considered when they are + really needed. Capabilities include: date-time parsing, formatting, + arithmetic, extraction and updating of components, and rounding. } \seealso{ Useful links: From 426bd2c294d344a65b7c945d0dee1383150169a3 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 08:59:30 -0400 Subject: [PATCH 07/12] Update URLs --- README.Rmd | 2 +- README.md | 2 +- vignettes/clock.Rmd | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.Rmd b/README.Rmd index b8919a52..b843dc86 100644 --- a/README.Rmd +++ b/README.Rmd @@ -15,7 +15,7 @@ knitr::opts_chunk$set( ) ``` -# clock +# clock [![Codecov test coverage](https://codecov.io/gh/r-lib/clock/branch/master/graph/badge.svg)](https://codecov.io/gh/r-lib/clock?branch=master) diff --git a/README.md b/README.md index 4da71685..d792e351 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ -# clock +# clock diff --git a/vignettes/clock.Rmd b/vignettes/clock.Rmd index 728f16e3..ad92c58d 100644 --- a/vignettes/clock.Rmd +++ b/vignettes/clock.Rmd @@ -21,7 +21,7 @@ library(clock) library(magrittr) ``` -The goal of this vignette is to introduce you to clock's high-level API, which works directly on R's built-in date-time types, Date and POSIXct. For an overview of all of the functionality in the high-level API, check out the pkgdown reference section, [High Level API](https://r-lib.github.io/clock/reference/index.html#section-high-level-api). One thing you should immediately notice is that every function specific to R's date and date-time types are prefixed with `date_*()`. There are also additional functions for arithmetic (`add_*()`) and getting (`get_*()`) or setting (`set_*()`) components that are also used by other types in clock. +The goal of this vignette is to introduce you to clock's high-level API, which works directly on R's built-in date-time types, Date and POSIXct. For an overview of all of the functionality in the high-level API, check out the pkgdown reference section, [High Level API](https://clock.r-lib.org/reference/index.html#section-high-level-api). One thing you should immediately notice is that every function specific to R's date and date-time types are prefixed with `date_*()`. There are also additional functions for arithmetic (`add_*()`) and getting (`get_*()`) or setting (`set_*()`) components that are also used by other types in clock. As you'll quickly see in this vignette, one of the main goals of clock is to guard you, the user, from unexpected issues caused by frustrating date manipulation concepts like invalid dates and daylight saving time. It does this by letting you know as soon as one of these issues happens, giving you the power to handle it explicitly with one of a number of different resolution strategies. From 706e76c2609fd82df04b1d43b30e9d0e6b818179 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 09:04:34 -0400 Subject: [PATCH 08/12] Update cran-comments check results. tzdata is now in tzdb. --- cran-comments.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 70c6309d..68456c7b 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -5,10 +5,9 @@ * This is a new release. * checking installed package size ... NOTE - installed size is 8.6Mb + installed size is 7.8Mb sub-directories of 1Mb or more: - libs 5.4Mb - tzdata 1.3Mb + libs 5.6Mb ## 0.1.0 Submission From 3061e7810eb8567f1c7f5f5c84a9e63deadbcecd Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 09:08:56 -0400 Subject: [PATCH 09/12] Typo --- R/posixt.R | 2 +- man/posixt-arithmetic.Rd | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/R/posixt.R b/R/posixt.R index 0f7f8cad..e0d658a7 100644 --- a/R/posixt.R +++ b/R/posixt.R @@ -444,7 +444,7 @@ arith_duration_and_posixt <- function(op, x, y, ...) { #' yourself. For example, you could convert the previous example to a #' naive-time instead of a sys-time manually with [as_naive_time()], add #' 1 second giving `"2020-03-08 02:00:00"`, then convert back to a -#' POSIXct/POSIXlt, dealing with the nonexistent time that get's created by +#' POSIXct/POSIXlt, dealing with the nonexistent time that gets created by #' using the `nonexistent` argument of `as.POSIXct()`. #' #' @inheritParams add_years diff --git a/man/posixt-arithmetic.Rd b/man/posixt-arithmetic.Rd index 7fb72f99..164fae57 100644 --- a/man/posixt-arithmetic.Rd +++ b/man/posixt-arithmetic.Rd @@ -197,7 +197,7 @@ heuristic for any reason, you can take control and perform the conversions yourself. For example, you could convert the previous example to a naive-time instead of a sys-time manually with \code{\link[=as_naive_time]{as_naive_time()}}, add 1 second giving \code{"2020-03-08 02:00:00"}, then convert back to a -POSIXct/POSIXlt, dealing with the nonexistent time that get's created by +POSIXct/POSIXlt, dealing with the nonexistent time that gets created by using the \code{nonexistent} argument of \code{as.POSIXct()}. } \examples{ From 902ed10d1b31c369a53e7837eb5d3f37814c350b Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 09:09:28 -0400 Subject: [PATCH 10/12] Increment version number --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 868fd255..e2e32ee2 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: clock Title: Date-Time Types and Tools -Version: 0.0.0.9000 +Version: 0.1.0 Authors@R: c(person(given = "Davis", family = "Vaughan", From 30ee9a18b059d41b6aa3e8a408384726047ee284 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 29 Mar 2021 09:35:27 -0400 Subject: [PATCH 11/12] CRAN-RELEASE --- .Rbuildignore | 1 + CRAN-RELEASE | 2 ++ 2 files changed, 3 insertions(+) create mode 100644 CRAN-RELEASE diff --git a/.Rbuildignore b/.Rbuildignore index 693ec428..b31f52c6 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -11,3 +11,4 @@ ^pkgdown$ ^vignettes/articles$ ^cran-comments\.md$ +^CRAN-RELEASE$ diff --git a/CRAN-RELEASE b/CRAN-RELEASE new file mode 100644 index 00000000..9c70918e --- /dev/null +++ b/CRAN-RELEASE @@ -0,0 +1,2 @@ +This package was submitted to CRAN on 2021-03-29. +Once it is accepted, delete this file and tag the release (commit 902ed10). From 7b23065a8dd0afcdcfc4ea1c1246e48ace4d1154 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Wed, 31 Mar 2021 08:28:18 -0400 Subject: [PATCH 12/12] Delete CRAN-RELEASE --- CRAN-RELEASE | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 CRAN-RELEASE diff --git a/CRAN-RELEASE b/CRAN-RELEASE deleted file mode 100644 index 9c70918e..00000000 --- a/CRAN-RELEASE +++ /dev/null @@ -1,2 +0,0 @@ -This package was submitted to CRAN on 2021-03-29. -Once it is accepted, delete this file and tag the release (commit 902ed10).