Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag extension functions #2

Closed
hadley opened this issue May 24, 2018 · 2 comments

Comments

@hadley
Copy link
Member

commented May 24, 2018

e.g. dplyr::intersects() makes base::intersect() generic so it shouldn't ever cause problems.

@hadley

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

Latest syntax proposal:

conflict_superset("use_test", "usethis", "devtools")

As suggested in #8, conflicted will assume that any function that overrides a base function follows the superset principle, unless it has attribute conflicted_superset equal to FALSE.

@hadley

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2018

conflict_superset() appears to be identical to conflict_prefer() so there's no need to implement.

dplyr::filter() and dplyr::lag() are the only functions that I know of that violate the superset principle, so I've hard coded them for now, instead of making extensible. We can reconsider in the future if other functions are discovered.

@hadley hadley closed this in b1d828f Aug 22, 2018

hadley added a commit that referenced this issue Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.