Skip to content
Permalink
Browse files
Enforce using HTTP 1.1
The codecov service seems to have issues with HTTP 2 and projects with
lots of data, e.g. ggplot2. Requiring HTTP 1.1 seems to fix the issue.

Fixes tidyverse/ggplot2#3862
  • Loading branch information
jimhester committed Mar 16, 2020
1 parent cc00632 commit cc710804aeff6f337777465bf902914197c0b713
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
@@ -55,6 +55,7 @@ Imports:
yaml
Suggests:
R6,
curl,
knitr,
rmarkdown,
htmltools,
@@ -202,7 +202,12 @@ codecov <- function(...,

coverage_json <- to_codecov(coverage)

httr::content(httr::POST(url = codecov_url, query = codecov_query, body = coverage_json, encode = "json"))
httr::content(httr::POST(url = codecov_url, query = codecov_query, body = coverage_json, encode = "json", httr::config(http_version = curl_http_1_1())))
}

curl_http_1_1 <- function() {
symbols <- curl::curl_symbols()
symbols$value[symbols$name == "CURL_HTTP_VERSION_1_1"]
}

extract_from_yaml <- function(path){

0 comments on commit cc71080

Please sign in to comment.