-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should cpp11 support string_view? #37
Comments
I don't think it is entirely trivial to do this. First as you mentioned we would need to use compatibility library so we could use it with C++11. Second and perhaps more importantly cpp11 uses It might be that this particular case is rare enough and the benefits of string_view are substantial enough that it makes sense, I am not sure. |
Another pretty serious issue with using |
Yeah the point about possible allocation by
|
Closing this issue for now, while I do think using string_view is a nice idea in theory, I don't think it really will work in practice for cpp11 due to the concerns expressed above. |
R strings seem like a pretty perfect use case for std::string_view. For compilers that don't support c++17, there are backports available. Any interest in a pull request?
The text was updated successfully, but these errors were encountered: