From 4f332df87a2f4f2ca2ee14b2ccf8fa997255c1e5 Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Wed, 17 Aug 2022 09:19:30 -0400 Subject: [PATCH 1/4] Use Intel specific pragma to disable unknown attribute warning --- inst/include/cpp11/R.hpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/inst/include/cpp11/R.hpp b/inst/include/cpp11/R.hpp index 463256d3..7ff355e1 100644 --- a/inst/include/cpp11/R.hpp +++ b/inst/include/cpp11/R.hpp @@ -13,12 +13,16 @@ #include "Rinternals.h" // clang-format off -#ifdef __clang__ +#if defined(__INTEL_COMPILER) +# pragma warning(disable : 3924) +#endif + +#if defined(__clang__) # pragma clang diagnostic push # pragma clang diagnostic ignored "-Wattributes" #endif -#ifdef __GNUC__ +#if defined(__GNUC__) && !defined(__clang__) && !defined(__INTEL_COMPILER) # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wattributes" #endif From bbf030f92244f27a10c0fc076d236fe99703fc7d Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Mon, 22 Aug 2022 09:00:40 -0400 Subject: [PATCH 2/4] NEWS bullet --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index 32184511..b029fae4 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # cpp11 (development version) +* Silenced an unknown attribute warning specific to the Intel compiler (#98). + # cpp11 0.4.3 * Modernized the GitHub Actions workflows and updated some internal tests to From 72921277df07343502fd5e5bad6e1005ce8cf78c Mon Sep 17 00:00:00 2001 From: Davis Vaughan Date: Fri, 11 Nov 2022 13:38:17 -0500 Subject: [PATCH 3/4] Update NEWS.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Romain François --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index b029fae4..84a6b219 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,6 @@ # cpp11 (development version) -* Silenced an unknown attribute warning specific to the Intel compiler (#98). +* Silenced an unknown attribute warning specific to the Intel compiler (r-lib/systemfonts#98). # cpp11 0.4.3 From 3561fcc73d2c52a888401f6fb55fdb6d4d4f7d6f Mon Sep 17 00:00:00 2001 From: DavisVaughan Date: Fri, 11 Nov 2022 13:39:45 -0500 Subject: [PATCH 4/4] Wrap to 80 characters --- NEWS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 84a6b219..d73c0d3d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,7 @@ # cpp11 (development version) -* Silenced an unknown attribute warning specific to the Intel compiler (r-lib/systemfonts#98). +* Silenced an unknown attribute warning specific to the Intel compiler + (r-lib/systemfonts#98). # cpp11 0.4.3