Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http:// vs https:// in hardcoded repositories #1059

Closed
bbolker opened this issue Feb 1, 2016 · 3 comments
Closed

http:// vs https:// in hardcoded repositories #1059

bbolker opened this issue Feb 1, 2016 · 3 comments
Milestone

Comments

@bbolker
Copy link
Contributor

@bbolker bbolker commented Feb 1, 2016

There are a few places where the RStudio CRAN mirror (cran.studio.com) is hard-coded, for convenience (e.g. functions that will get used non-interactively, where user may not have set repo in their .Rprofile). Right now these are hard-coded as http://..., which causes various difficulties when using R-devel (which insists on https:// in many important contexts) - specifically, dependencies may fail to be found when installing packages. In particular, changing http:// to https:// in line 56 of deps.R fixes a lot of problems ...

@hadley
Copy link
Member

@hadley hadley commented Feb 1, 2016

Want to do a PR?

@bbolker
Copy link
Contributor Author

@bbolker bbolker commented Feb 1, 2016

OK, although does it need to be/should it be conditional on R >= 3.3.0? (I thought there were other uses of hard-coded http://, but I think I was wrong)

@hadley hadley added this to the 1.12.0 milestone Jun 3, 2016
hadley added a commit that referenced this issue Jun 3, 2016
Fixes #1059
hadley added a commit that referenced this issue Jun 3, 2016
@hadley hadley closed this in #1203 Jun 3, 2016
hadley added a commit that referenced this issue Jun 3, 2016
* Pick https mirror if possible.

Fixes #1059

* Add NEWS bullet

* Check for libcurl

* Remove RStudio license block

* Correct issue number

* Merge conflict?
@lock
Copy link

@lock lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants