New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host argument to use_github()? #1101

Closed
ijlyttle opened this Issue Feb 27, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ijlyttle
Contributor

ijlyttle commented Feb 27, 2016

Hi,

The use-case for this is for people who use enterprise GitHub.

I have looked at the code, and I think this can be done, but it would involve (I think) also adding a host argument to:

  • github_GET()
  • github_POST()
  • use_github_links()

The change to use_github_links() could be a bit hairy as it might have to map api.github.com to https://github.com and github.foo.com/api/v3 to https://github.foo.com.

I am happy to do a PR on this, if you think it is worthwhile to go forward. If so, a couple quick questions:

  1. Are there other functions I would need to touch?
  2. I also see a problem in testing the code, as it would require a public enterprise version of github to test against. Would it be enough to do private, informal testing, and also (of course) ensure that any changes do not break the existing behavior?
@hadley

This comment has been minimized.

Member

hadley commented Mar 23, 2016

I'd be happy to review a PR of this. I don't think you need to worry too much about testing - as long as it works for public github, and the url is pluggable, it should work for any internal github.

@ijlyttle

This comment has been minimized.

Contributor

ijlyttle commented Mar 24, 2016

Will do - thanks!

@ijlyttle

This comment has been minimized.

Contributor

ijlyttle commented Jun 11, 2016

done in #1215

@lock

This comment has been minimized.

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.