New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check() should use rcmdcheck() #1153

Closed
imanuelcostigan opened this Issue Apr 16, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@imanuelcostigan
Contributor

imanuelcostigan commented Apr 16, 2016

The latter has much better log formatting than the default R log.

rcmdcheck repo here

@hadley hadley added this to the 1.12.0 milestone Jun 2, 2016

@hadley

This comment has been minimized.

Member

hadley commented Jun 2, 2016

Not on CRAN yet

@hadley hadley removed this from the 1.12.0 milestone Jun 2, 2016

@jimhester

This comment has been minimized.

Member

jimhester commented Jun 2, 2016

@hadley

This comment has been minimized.

Member

hadley commented Jun 2, 2016

Ooops, I was looking for "rmdcheck"

@hadley

This comment has been minimized.

Member

hadley commented Jun 2, 2016

Looking at a bit more, I don't think we can switch now because we have so much custom logic about envvars etc. Switching engines would be a lot of work

@jimhester

This comment has been minimized.

Member

jimhester commented Jun 2, 2016

Probably true, I guess this can stay on the backlog until we can get to it.

@imanuelcostigan

This comment has been minimized.

Contributor

imanuelcostigan commented Jun 2, 2016

is it bad form to 👍 ones own issue? Too late...

@hadley hadley added feature rcmd and removed rcmd labels Nov 3, 2016

jimhester added a commit to jimhester/devtools that referenced this issue Aug 1, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Aug 1, 2017

@hadley hadley added has-pr and removed check labels Aug 2, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Aug 15, 2017

@jimhester jimhester closed this in 8e61870 Aug 15, 2017

@lock

This comment has been minimized.

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.