/devtools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean_dll should not delete .def files #1159

Closed
jeroen opened this Issue Apr 21, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jeroen
@jeroen
Member

jeroen commented Apr 21, 2016

Def files are often part of source code, for example in the mongolite package. They should not be deleted: https://github.com/hadley/devtools/blob/b6a23be508043fd0ffc24316034b5e45bfc1a941/R/compile-dll.r#L54

@jimhester jimhester referenced this issue Apr 27, 2016

Merged

Only clean def files if they are 'packageName.def' #1161

@hadley hadley closed this in #1161 Jun 2, 2016

@lock

This comment has been minimized.

Sign in to view

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.