New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git tagging to devtools::release() #1198

Closed
adamobeng opened this Issue Jun 1, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@adamobeng

adamobeng commented Jun 1, 2016

Many R packages, including those in rOpenSci use git tags/github releases to identify their CRAN releases, and include updates from the NEWS file in the GitHub release info.

Could this be automated as part of devtools::release()?

(cc @scottkosty, @njtierney, @kbenoit)

@wch

This comment has been minimized.

Member

wch commented Jun 1, 2016

One problem is that, right after you run release(), you can't be sure that the submitted package will actually be accepted onto CRAN without any revisions.

@kbenoit

This comment has been minimized.

kbenoit commented Jun 1, 2016

Or that Brian Ripley won't give you two weeks to upload a revision, after it's been published, to fix a single non-ASCII character in an .Rd file!

In practice the revisions that @wch refers to happen all the time immediately after first submission.

@hadley hadley closed this Jun 2, 2016

@wch

This comment has been minimized.

Member

wch commented Jun 2, 2016

Just another thought about this: One thing that release() could do is to write a file named "released_to_cran" to package directory, with some content like: "This package was sent to CRAN with devtools::release(). If it was accepted, you should remove this file and tag the commit that was released (a3728b). If it was rejected, just remove this file."

Seeing the file there would serve as a reminder to tag the commit before committing more code.

@hadley

This comment has been minimized.

Member

hadley commented Jun 2, 2016

Oh I like that idea!

@hadley hadley reopened this Jun 2, 2016

@hadley hadley added release and removed rcmd labels Aug 2, 2017

@hadley hadley closed this in b05bd25 Aug 2, 2017

@lock

This comment has been minimized.

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.