New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should submit_cran() emit a warning or ask for confirmation? #1228

Closed
rpruim opened this Issue Jun 16, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@rpruim

rpruim commented Jun 16, 2016

It is easy to spot this (say by auto-completion) and think it is what release() is. (Someone I know may have done this ;-) Perhaps an argument could be added to avoid this when called from within other functions (like release()) but alert interactive users to the existence of release(), since that is likely what they want.

@hadley

This comment has been minimized.

Member

hadley commented Jun 16, 2016

It doesn't feel too dangerous to me as you still have to confirm submission with the email link.

@hadley

This comment has been minimized.

Member

hadley commented Jun 26, 2016

submit_cran() should probably work the same way as build_win(), i.e. move the confirmation & email check out of release().

@hadley hadley added feature rcmd and removed rcmd labels Nov 3, 2016

@hadley hadley added release and removed check labels Aug 2, 2017

@hadley hadley closed this in b2f9d59 Aug 2, 2017

@lock

This comment has been minimized.

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.