Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check(check_version = FALSE) should use _R_CHECK_CRAN_INCOMING_REMOTE_ #1271

Closed
dmurdoch opened this issue Jul 20, 2016 · 4 comments
Closed
Labels
feature a feature request or enhancement

Comments

@dmurdoch
Copy link
Contributor

Currently the check_version option of devtools::check() defaults to FALSE. When FALSE, it sets _R_CHECK_CRAN_INCOMING_ to false, which does a lot more than just turning off the version checks: it also turns off a bunch of style checks which can cause a package to be rejected by CRAN. Those style checks are quick, unlike the version number check, which can be quite slow.

I've just added a new environment variable to R-devel (as of revision r70944) called _R_CHECK_CRAN_INCOMING_REMOTE_ which is a more appropriate variable to set false by default. It keeps the quick local checks, but turns off the remote ones, including the version check. (The style checks will still only be run if _R_CHECK_CRAN_INCOMING_ is true, e.g. if --as-cran is given as a check option.)

It's not clear yet whether this will make it into R-patched, so for now it should only be used if

getRversion() >= "3.4.0" && as.numeric(R.version[["svn rev"]]) >= 70944
@hadley hadley added feature a feature request or enhancement rcmd and removed rcmd labels Nov 3, 2016
@hadley
Copy link
Member

hadley commented Nov 11, 2016

@dmurdoch I'm finally getting around to implementing this. Did it make it into R-patched?

@dmurdoch
Copy link
Contributor Author

No, it's still only in R-devel. It probably should go into R-patched, I just haven't had time. If you're planning a devtools update soon I'll try to push it forward, but otherwise I'd like to wait until things calm down here in December.

@hadley
Copy link
Member

hadley commented Nov 11, 2016

I'm working on devtools at the moment, but we're planning for a big release (splitting devtools up into many smaller pieces), so it's unlikely to be ready this year.

@lock
Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants