Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_all() and test() don't load package dependencies? #1472

Closed
fruce-ki opened this issue Mar 9, 2017 · 3 comments
Closed

load_all() and test() don't load package dependencies? #1472

fruce-ki opened this issue Mar 9, 2017 · 3 comments

Comments

@fruce-ki
Copy link

@fruce-ki fruce-ki commented Mar 9, 2017

Please see issues linked below.

Rdatatable/data.table#2023
Rdatatable/data.table#2053

It seems that test() and load_all() and possibly others have recently changed behaviour with regards to resolving imported packages, at least with regards to the 'data.table' package.

Testing of perfectly valid code should not fail like that.

@hadley
Copy link
Member

@hadley hadley commented Aug 1, 2017

data.table uses some magic to determine if it's needed or not. Clearly the magic is failing due to the special way that load_all() simulates package loading.

I'd recommend filing a minimal reproducible example at pkgbuild, which is where the package loading code now lives. You'll probably need to create a minimal package that illustrates the problem and host it on github.

@hadley hadley closed this as completed Aug 1, 2017
@hadley
Copy link
Member

@hadley hadley commented Aug 2, 2017

Sorry, I meant pkgload, not pkgbuild

@lock
Copy link

@lock lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants