Skip to content

check function naming #1598

Closed
Closed

Description

@jimhester

Should we rename build_win() to check_win() and rhub_check() to check_rhub() to make the names more consistent and easier to discover?

Activity

  1. hadley commented on Aug 28, 2017

    @hadley
    Member

    Yes!

  2. hadley commented on Oct 18, 2017

    @hadley
    Member

    I think we should also have check_win_devel() and check_win_release() just because for the last year I thought build_win() defaulted to "R-devel" (and typically you only want to run one)

  3. jimhester commented on Oct 18, 2017

    @jimhester
    MemberAuthor

    I am not really sure why the code it written as it is, having 'R-release' first in the default argument does make it seem like it would default to 'R-release', but it does default to R-devel

    https://github.com/hadley/devtools/blob/a0c8d7333be185f979a60823dcfad66c9f3ea35e/R/build-win.r#L23-L24

    Anyway, I agree having separate functions makes sense to me.

  4. self-assigned this
    on Oct 18, 2017
  5. hadley commented on Oct 18, 2017

    @hadley
    Member

    Oh that is super confusing!

  6. added 6 commits that reference this issue on Oct 18, 2017
    60ac8f0
    4ced1a0
    7de9bb8
    b93f857
    421e923
    3aa9fc5
  7. added a commit that references this issue on Oct 19, 2017
    49bf361
  8. tbates commented on Oct 29, 2017

    @tbates

    Just to note that this is currently backwards incompatible and requires some coding changes in consuming packages. (now getting an error from release check in code updated for dev version).

    devtools::check_win()
    
    Missing or unexported object: ‘devtools::check_win’
    packageVersion("devtools")
    [1] ‘1.13.3’
    
  9. lock commented on Sep 17, 2018

    @lock

    This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

  10. locked and limited conversation to collaborators on Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featurea feature request or enhancement

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions