You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should also have check_win_devel() and check_win_release() just because for the last year I thought build_win() defaulted to "R-devel" (and typically you only want to run one)
I am not really sure why the code it written as it is, having 'R-release' first in the default argument does make it seem like it would default to 'R-release', but it does default to R-devel
Just to note that this is currently backwards incompatible and requires some coding changes in consuming packages. (now getting an error from release check in code updated for dev version).
devtools::check_win()
Missing or unexported object: ‘devtools::check_win’
packageVersion("devtools")
[1] ‘1.13.3’
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/
Activity
hadley commentedon Aug 28, 2017
Yes!
hadley commentedon Oct 18, 2017
I think we should also have
check_win_devel()andcheck_win_release()just because for the last year I thoughtbuild_win()defaulted to "R-devel" (and typically you only want to run one)jimhester commentedon Oct 18, 2017
I am not really sure why the code it written as it is, having 'R-release' first in the default argument does make it seem like it would default to 'R-release', but it does default to R-devel
https://github.com/hadley/devtools/blob/a0c8d7333be185f979a60823dcfad66c9f3ea35e/R/build-win.r#L23-L24
Anyway, I agree having separate functions makes sense to me.
hadley commentedon Oct 18, 2017
Oh that is super confusing!
Rename build_win to check_win
Rename rhub_check to check_rhub
Rename build_win to check_win
Rename rhub_check to check_rhub
Rename build_win to check_win
Rename rhub_check to check_rhub
Rename build_win to check_win_* and rename rhub_check to check_rhub (#…
tbates commentedon Oct 29, 2017
Just to note that this is currently backwards incompatible and requires some coding changes in consuming packages. (now getting an error from release check in code updated for dev version).
lock commentedon Sep 17, 2018
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/