check function naming

[jimhester]

Should we rename build_win() to check_win() and rhub_check() to check_rhub() to make the names more consistent and easier to discover?

[hadley]

Yes!

[hadley]

I think we should also have check_win_devel() and check_win_release() just because for the last year I thought build_win() defaulted to "R-devel" (and typically you only want to run one)

[jimhester]

I am not really sure why the code it written as it is, having 'R-release' first in the default argument does make it seem like it would default to 'R-release', but it does default to R-devel

https://github.com/hadley/devtools/blob/a0c8d7333be185f979a60823dcfad66c9f3ea35e/R/build-win.r#L23-L24

Anyway, I agree having separate functions makes sense to me.

[hadley]

Oh that is super confusing!

[tbates]

Just to note that this is currently backwards incompatible and requires some coding changes in consuming packages. (now getting an error from release check in code updated for dev version).

devtools::check_win()

Missing or unexported object: ‘devtools::check_win’
packageVersion("devtools")
[1] ‘1.13.3’

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/