New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check function naming #1598

Closed
jimhester opened this Issue Aug 28, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@jimhester
Member

jimhester commented Aug 28, 2017

Should we rename build_win() to check_win() and rhub_check() to check_rhub() to make the names more consistent and easier to discover?

@hadley

This comment has been minimized.

Member

hadley commented Aug 28, 2017

Yes!

@hadley

This comment has been minimized.

Member

hadley commented Oct 18, 2017

I think we should also have check_win_devel() and check_win_release() just because for the last year I thought build_win() defaulted to "R-devel" (and typically you only want to run one)

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 18, 2017

I am not really sure why the code it written as it is, having 'R-release' first in the default argument does make it seem like it would default to 'R-release', but it does default to R-devel

https://github.com/hadley/devtools/blob/a0c8d7333be185f979a60823dcfad66c9f3ea35e/R/build-win.r#L23-L24

Anyway, I agree having separate functions makes sense to me.

@hadley hadley added the feature label Oct 18, 2017

@jimhester jimhester self-assigned this Oct 18, 2017

@hadley

This comment has been minimized.

Member

hadley commented Oct 18, 2017

Oh that is super confusing!

jimhester added a commit to jimhester/devtools that referenced this issue Oct 18, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Oct 18, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Oct 19, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Oct 19, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Oct 19, 2017

jimhester added a commit to jimhester/devtools that referenced this issue Oct 19, 2017

@hadley hadley closed this in #1626 Oct 19, 2017

hadley added a commit that referenced this issue Oct 19, 2017

Rename build_win to check_win_* and rename rhub_check to check_rhub (#…
…1626)

* Rename build_win to check_win

Fixes #1598

* Rename rhub_check to check_rhub

Fixes #1598

* Add note to NEWS

* Re-document
@tbates

This comment has been minimized.

tbates commented Oct 29, 2017

Just to note that this is currently backwards incompatible and requires some coding changes in consuming packages. (now getting an error from release check in code updated for dev version).

devtools::check_win()

Missing or unexported object: ‘devtools::check_win’
packageVersion("devtools")
[1] ‘1.13.3’
@lock

This comment has been minimized.

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.