New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_* requires user to have pdftex if package has a vignette #173

Closed
garrettgman opened this Issue Oct 16, 2012 · 5 comments

Comments

Projects
None yet
4 participants
@garrettgman

garrettgman commented Oct 16, 2012

This might be something you guys want to think about. When a person runs install_github (and maybe other install_*'s), devtools retrieves a copy of the package, and then R builds and installs it on the user's machine.

If the package has an Sweave vignette, R build will try to find a program to compile the vignette and then error out if the user doesn't have one.

I'm guessing that a lot of R users won't have latex installed and won't be able to figure out the error message, which may make it harder to use install_github and github.

Garrett

p.s. Also, I could be completely wrong about this :P

@garrettgman

This comment has been minimized.

garrettgman commented Oct 16, 2012

We should attempt to detect if pdftex is available, and if not, don't try and install vignettes. - Hadley

@hadley

This comment has been minimized.

Member

hadley commented Dec 12, 2012

Check for Sys.which("pdflatex")

@hadley

This comment has been minimized.

Member

hadley commented Dec 14, 2012

And pass --no-manual, --no-vignettes to build and check.

@bbolker

This comment has been minimized.

Contributor

bbolker commented Dec 15, 2012

one quick thought: is specifying quick=TRUE a temporary workaround for this issue?

@wch

This comment has been minimized.

Member

wch commented Dec 16, 2012

@bbolker no, quick=TRUE presently doesn't affect vignette building. The vignettes are built during the build phase, not the install phase, and quick=TRUE only affects the install phase.

@wch wch closed this in 48eb7b9 Dec 16, 2012

wch added a commit that referenced this issue Dec 16, 2012

Merge pull request #216 from wch/no-vignette
build: if pdflatex not present, don't build vignettes. Fixes #173

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.