Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If codemeta.json is present, add release question to prompt update #1774

Closed
hadley opened this Issue Apr 26, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@hadley
Copy link
Member

hadley commented Apr 26, 2018

No description provided.

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Apr 26, 2018

@maelle actually had an issue for this #1754, which we decided to close in favor of package authors adding a release_questions object to their package rather than adding additional logic to devtools. But if we (tidyverse team) are going to start using this we can add it.

@maelle

This comment has been minimized.

Copy link
Contributor

maelle commented Apr 26, 2018

What happens now in write_codemeta when called inside a package project

  • Rbuildignore codemeta.json

  • Adds pre-commit git hook

  • Message suggesting adding the release question (which is a bit superfluous given there's a git hook).

We're actually working on a codemetar CRAN release for yesterday 😂 (release failed, we'll try again today).

Does it make sense to suggest this release question if you're going to add it to devtools? If you add it and someone has the question inside their code they'll get asked the same question twice upon devtools::release unless the phrasing is the same and devtools only asks unique questions?

@maelle

This comment has been minimized.

Copy link
Contributor

maelle commented Apr 26, 2018

@hadley

This comment has been minimized.

Copy link
Member Author

hadley commented Apr 26, 2018

I think we'll use this in enough places it's worth baking in to devtools

@jimhester jimhester added the feature label May 4, 2018

@jimhester jimhester added this to the 2.0.0 milestone Jul 18, 2018

@jimhester jimhester closed this in 7a69ae2 Jul 18, 2018

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Jul 18, 2018

Ok this question is now included in devtools::release() if a codemeta.json file exists.

@lock

This comment has been minimized.

Copy link

lock bot commented Jan 14, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.