Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate where get_path() and friends belong #1796

Closed
jennybc opened this issue Jun 5, 2018 · 3 comments
Closed

Evaluate where get_path() and friends belong #1796

jennybc opened this issue Jun 5, 2018 · 3 comments
Labels
Milestone

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Jun 5, 2018

Is devtools still the forever home for get_path(), set_path(path), and add_path(path, after = Inf)? I came across these in a disambiguation prompt when seeking help on fs::path(). The latter two definitely feel more like withr functions now.

@jimhester
Copy link
Member

@jimhester jimhester commented Jun 6, 2018

withr has with_path(), so you can get the same behavior as add_path(after = Inf) with withr::with_path(path, action = "suffix").

It doesn't seem like these functions are used by any packages on CRAN (including devtools) so maybe we should just remove them entirely?

@jennybc
Copy link
Member Author

@jennybc jennybc commented Jun 6, 2018

I can convince myself either way, but The Great Devtools Breakup certainly feels like a good time to clean out the proverbial closet.

@jimhester jimhester added the feature label Jun 29, 2018
@jimhester jimhester added this to the 2.0.0 milestone Jul 18, 2018
@jimhester jimhester closed this in dbf0024 Jul 18, 2018
@lock
Copy link

@lock lock bot commented Jan 14, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 14, 2019
HughParsonage added a commit to HughParsonage/devtools that referenced this issue Jul 2, 2019
These were unused by devtools or packages on CRAN and the functionality
has been moved to withr.

Fixes r-lib#1796
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants