Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools not producing some NOTES or WARNINGS #1811

Closed
IndrajeetPatil opened this issue Jul 5, 2018 · 3 comments
Closed

devtools not producing some NOTES or WARNINGS #1811

IndrajeetPatil opened this issue Jul 5, 2018 · 3 comments
Labels
Milestone

Comments

@IndrajeetPatil
Copy link

@IndrajeetPatil IndrajeetPatil commented Jul 5, 2018

I am using devtools 1.13.6 on a Windows 10 machine. It has happened to me multiple times now where I run devtools::check() and some rhub checks, get 0 Errors | 0 Warnings | 0 Notes, and then submit to CRAN and get either warnings or notes that I hadn't seen before and have my package rejected:

For example-

  1. Bad URLs (not found with devtools, but spotted by CRAN's R CMD CHECK)
Found the following (possibly) invalid URLs:
  URL: https://indrajeetpatil.github.io/ggstatsplot/articles/ggspiestats.html
    From: inst/doc/ggcoefstats.html
    Status: 404
    Message: Not Found
  1. Unused dependencies (not found by devtools, but by rhub)

image

  1. Avoiding running spell check test on CRAN servers
    r-lib/usethis#408

Am I doing something wrong? Are there some other checks I should be running with devtools, in addition to devtools::check() and devtools::check_win_devel() that can help me catch errors like these?

@jimhester
Copy link
Member

@jimhester jimhester commented Jul 5, 2018

devtools::check() by default does not run the 'version' or 'incoming' checks, because they take a while to run and have to check CRANs or other external servers. You can run them by passing devtools::check(check_version = TRUE)

devtools::check_win_devel() runs on win-builder, which is an identical setup to the CRANs autocheck makines, so it will give you the same results as what you would get when submitting to CRAN.

@jimhester jimhester closed this Jul 5, 2018
@jimhester jimhester reopened this Jul 5, 2018
@jimhester
Copy link
Member

@jimhester jimhester commented Jul 5, 2018

It is possible this could be better documented, or the argument could be renamed to make it more clear which tests are suppressed.

@jimhester jimhester added this to the 2.0.0 milestone Jul 18, 2018
@jimhester jimhester closed this in cda06de Jul 18, 2018
@lock
Copy link

@lock lock bot commented Jan 14, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 14, 2019
HughParsonage added a commit to HughParsonage/devtools that referenced this issue Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants