Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_all helper? #1850

Closed
hadley opened this Issue Aug 18, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@hadley
Copy link
Member

hadley commented Aug 18, 2018

  if (rstudioapi::hasFun("documentSaveAll")) {
    rstudioapi::documentSaveAll()
  }

Is repeated in a lot of places. If it was extracted out, you could also imagine adding implementations for other editors.

@jimhester jimhester added the feature label Aug 20, 2018

@AmundsenJunior

This comment has been minimized.

Copy link
Contributor

AmundsenJunior commented Sep 7, 2018

I'm considering two ways of implementing this. First option is to place a save_all() function into R/utils.R. I'm not sure that this is the best location, if we are anticipating expanding with impls for other editors. In that case, it makes more sense to me to create R/save-all.R, and export the function from that file.

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Sep 7, 2018

I think we should put it in R/save-all.R with an eye towards expanding the functionality to other editors in the future. Although doing so would likely require a package to communicate with them ala rstudioapi.

@AmundsenJunior

This comment has been minimized.

Copy link
Contributor

AmundsenJunior commented Sep 10, 2018

@jimhester created PR for save-all.R

jimhester added a commit that referenced this issue Sep 10, 2018

AmundsenJunior added a commit to AmundsenJunior/devtools that referenced this issue Sep 11, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 9, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Mar 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.