Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_github() gives Error in read.dcf(path) #1900

Closed
sfirke opened this Issue Oct 23, 2018 · 8 comments

Comments

Projects
None yet
7 participants
@sfirke
Copy link

sfirke commented Oct 23, 2018

> devtools::install_github("adamMaier/reviewr")
Error in read.dcf(path) : 
  Found continuation line starting '    wrangling steps, ...' at begin of record.

That text "wrangling steps" comes from the DESCRIPTION file in the above repo.

This install command ran successfully in devtools 1.13.5, then I tried it under devtools 2.0.0 when it failed for my colleague and indeed it fails for me too under 2.0.0. Nothing else changed between upgrading devtools so I expect this was introduced between 1.13.5 and 2.0.0. I'm on Windows.

Looks similar to #709.

@jimhester

This comment has been minimized.

@adamMaier

This comment has been minimized.

Copy link

adamMaier commented Oct 24, 2018

I fixed the two depends fields issues. But I was actually getting the same read.dcf error after that. I cut the number of spaces of indenting in the DESCRIPTION to 1 instead of 4, and that seemed to solve the issue.

@jimhester jimhester closed this Oct 24, 2018

magnusdv added a commit to magnusdv/pedtools that referenced this issue Oct 26, 2018

Remove line break
* trying to fix installation bug similar to r-lib/devtools#1900

syunsuke added a commit to rea-osaka/reti that referenced this issue Nov 12, 2018

jcvdav added a commit to turfeffect/MPAtools that referenced this issue Nov 20, 2018

@schuemie

This comment has been minimized.

Copy link

schuemie commented Dec 7, 2018

Voting to reopen this issue. I still get this error, but have a perfectly valid DESCRIPTION file (this example package happens to also live on CRAN, where there are no problems). I guess I might solve it by removing some extra spaces, but would hate to have to do that for all my prior Git tags. Code to reproduce the error:

devtools::install_github("ohdsi/SqlRender", ref = "v1.5.3")
# Error in read.dcf(path) : 
#  Found continuation line starting '    person("Martijn" ...' at begin of record.

Here's the DESCRIPTION file at that tag. Session info:

> sessionInfo()
R version 3.5.1 (2018-07-02)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252    LC_MONETARY=English_United States.1252
[4] LC_NUMERIC=C                           LC_TIME=English_United States.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.17      rstudioapi_0.7    magrittr_1.5      usethis_1.4.0     devtools_2.0.1    pkgload_1.0.2    
 [7] R6_2.2.2          rlang_0.2.1       tools_3.5.1       pkgbuild_1.0.2    sessioninfo_1.1.1 cli_1.0.0        
[13] withr_2.1.2       remotes_2.0.2     yaml_2.1.19       assertthat_0.2.0  digest_0.6.15     rprojroot_1.3-2  
[19] crayon_1.3.4      processx_3.1.0    callr_2.0.4       fs_1.2.6          curl_3.2          testthat_2.0.0   
[25] memoise_1.1.0     glue_1.2.0        compiler_3.5.1    desc_1.2.0        backports_1.1.2   prettyunits_1.0.2
@eaurele

This comment has been minimized.

Copy link

eaurele commented Dec 10, 2018

Same issue here, with a well-formed DESCRIPTION file ("ThinkR-open/shinytemplate"). Cloning and doing remotes::install_local() works though.

> remotes::install_github("Thinkr-open/shinytemplate")
Error in read.dcf(path) : 
  Found continuation line starting '    R (>= 3.0) ...' at begin of record.
$ git clone git@github.com:ThinkR-open/shinytemplate.git
> remotes::install_local()
These packages have more recent versions available.
Which would you like to update?

1:   jsonlite (1.5   -> 1.6  ) [CRAN]
2:   processx (3.2.0 -> 3.2.1) [CRAN]
3:   CRAN packages only
4:   All
5:   None

Enter one or more numbers separated by spaces, or an empty line to cancel
1: 5checking for file 'C:\Users\AureleMorovan\AppData\Local\Temp\RtmpQLVRJV\file38d4531863f1\shinytemplate/DESCRIPTION'
-  preparing 'shinytemplate':checking DESCRIPTION meta-information ... 
-  checking for LF line-endings in source and make files and shell scripts
-  checking for empty or unneeded directories
-  building 'shinytemplate_0.0.21.tar.gz'
   
Installing package intoC:/Users/AureleMorovan/Documents/R/win-library/3.5’
(aslibis unspecified)
* installing *source* package 'shinytemplate' ...
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
  converting help for package 'shinytemplate'
    finding HTML links ... done
    create_shiny_template                   html  
    get_dependencies                        html  
** building package indices
** testing if installed package can be loaded
*** arch - i386
*** arch - x64
* DONE (shinytemplate)
In R CMD INSTALL

> sessionInfo()
R version 3.5.1 (2018-07-02)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default

locale:
[1] LC_COLLATE=English_Netherlands.1252 
[2] LC_CTYPE=English_Netherlands.1252   
[3] LC_MONETARY=English_Netherlands.1252
[4] LC_NUMERIC=C                        
[5] LC_TIME=English_Netherlands.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets 
[6] methods   base     

loaded via a namespace (and not attached):
 [1] ps_1.2.1          prettyunits_1.0.2 withr_2.1.2      
 [4] rprojroot_1.3-2   crayon_1.3.4      assertthat_0.2.0 
 [7] R6_2.3.0          backports_1.1.2   magrittr_1.5     
[10] debugme_1.1.0     cli_1.0.1         remotes_2.0.2    
[13] rstudioapi_0.8    callr_3.0.0       tools_3.5.1      
[16] yaml_2.2.0        compiler_3.5.1    processx_3.2.0   
[19] base64enc_0.1-3   pkgbuild_1.0.2 

Note: I used remotes::install_* but same behavior with devtools::

@schuemie

This comment has been minimized.

Copy link

schuemie commented Jan 7, 2019

@jimhester : no comment? This effects quite a lot of users, and seems to be a genuine bug in devtools.

@pbr6cornell

This comment has been minimized.

Copy link

pbr6cornell commented Jan 11, 2019

I am running into the same issue identified by @schuemie and @eaurele . My only recourse was to revert to older version of devtools. But I dislike that 'solution', as I'd really like to keep up with all of the impressive work that this team is doing. Can we relax the DESCRIPTION file reader to more gracefully handle spaces?

@schuemie

This comment has been minimized.

Copy link

schuemie commented Jan 11, 2019

Digging into this, I found this problem has been fixed here in the remotes package. Until that makes it into CRAN, you can update remotes to the right point using

devtools::install_github("r-lib/remotes", ref = "e56a41e1d0cad55cbe7d60b274b99ab7b7a76b5c")
@Nelson-Gon

This comment has been minimized.

Copy link

Nelson-Gon commented Feb 5, 2019

This seems to be due to indentation. At least that fixed it for me.

@marcusvolz marcusvolz referenced this issue Feb 17, 2019

Closed

Install fails #4

danielcanueto added a commit to danielcanueto/rDolphin that referenced this issue Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.