New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could 'install_deps()' work within project sub-directory? #1905

Closed
kevinushey opened this Issue Oct 25, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kevinushey
Contributor

kevinushey commented Oct 25, 2018

E.g.

> devtools::install_deps()
Warning in read.dcf(path) :
  cannot open compressed file '/Users/kevin/r/pkg/Rcpp/inst/unitTests/DESCRIPTION', probable reason 'No such file or directory'
Error in read.dcf(path) : cannot open the connection

I was briefly working in the inst/unitTests folder for Rcpp; discovered I was missing some development dependencies, and was hoping an install_deps() would do the trick. It'd be nice if this function looked upwards for a package root + associated DESCRIPTION file.

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 25, 2018

This is how it used to work when install_deps() was in devtools, but the functions in remotes don't do this so we no longer have this functionality.

One way to get it back is to use devtools::package_file(), e.g.

devtools::install_deps(devtools::package_file())

@kevinushey

This comment has been minimized.

Contributor

kevinushey commented Oct 26, 2018

Do you think devtools / remotes should do this? Could they use rprojroot::find_package_root_file() as a default? Or should I just learn to live with the change in behavior?

@jimhester jimhester closed this in 4953bd6 Oct 26, 2018

@kevinushey

This comment has been minimized.

Contributor

kevinushey commented Oct 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment