Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_gist, source_url should have sha1 argument #259

Closed
wch opened this issue Feb 20, 2013 · 1 comment · Fixed by #274
Closed

source_gist, source_url should have sha1 argument #259

wch opened this issue Feb 20, 2013 · 1 comment · Fixed by #274
Milestone
1.2

Comments

@wch
Copy link
Member

wch commented Feb 20, 2013

Having a hash of the source file will help ensure that the remote file hasn't changed underneath you (with possibly negative results). It would be used like this:

source_url('http://something.com/foo.r', sha1='0123456789abcdef')
@hadley
Copy link
Member

hadley commented Mar 27, 2013

Do you mean it would hash the downloaded file and compare it to your sha1?

@wch wch mentioned this issue Apr 1, 2013
Merged
@hadley hadley closed this as completed in 6c0d1ad Apr 1, 2013
@lock lock bot locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add SHA1 check to source_url wch/devtools
2 participants
@hadley @wch