Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I override the `check` path? #337

Closed
yoni opened this Issue Aug 5, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@yoni
Copy link
Contributor

yoni commented Aug 5, 2013

I'm running continuous integration builds on a Jenkins server and need the R CMD check output to remain in the project working directory. Otherwise, I can't diagnose the issues on build failures.

I've tried a couple of approaches, including passing check(..., args=c('--output', 'my_check_dir')). The problem is, I'm pretty sure devtools overrides the path separately, resulting in a conflict.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Aug 8, 2013

It doesn't look like it. What about patching check() to return r_cmd_check_path in the case of failure, and then you could add custom handling? Alternatively, we could add the check_dir param to check() and pass that on down to check_r_cmd()

@yoni

This comment has been minimized.

Copy link
Contributor Author

yoni commented Aug 8, 2013

Thanks for the response, @hadley. :)

Returning r_cmd_check_path implies that the caller needs to add error handling to their code. I like the top-down check_dir option better.

@hadley hadley closed this in 14ffa43 Oct 7, 2013

@yoni

This comment has been minimized.

Copy link
Contributor Author

yoni commented Oct 7, 2013

Thanks for adding this, @hadley! It was on my TODO list, but I never quite got the time.

@lock lock bot locked and limited conversation to collaborators Sep 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.