New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools should include pkgs in VignetteBuilder as dependencies to download #396

Closed
kevinushey opened this Issue Dec 16, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@kevinushey
Contributor

kevinushey commented Dec 16, 2013

For example, currently installing Rcpp from GitHub fails if highlight is not available:

install_github("Rcpp", "RcppCore")

gives me

* creating vignettes ... ERROR
Error in loadVignetteBuilder(vigns$pkgdir) : 
  vignette builder 'highlight' not found

Of course, the error is easy enough for the user to fix, but it would be nice if devtools could automatically grab the package from CRAN.

@hadley

This comment has been minimized.

Member

hadley commented Mar 17, 2014

Should these packages be installed if deps = NA, or just if deps = T?

@hadley

This comment has been minimized.

Member

hadley commented Mar 17, 2014

Here's one interpretation: deps = NA means (approximately) get run-time dependencies, and deps = T means get build-time dependencies. So it should be added only when deps = TRUE, but install_github() should probably use deps = T since you have to build the package.

@wch

This comment has been minimized.

Member

wch commented Mar 18, 2014

I think the TRUE/FALSE/NA values aren't very intuitive. An alternative is to change dependencies to a string argument, and you could deprecate the TRUE/FALSE values.

@hadley

This comment has been minimized.

Member

hadley commented Mar 18, 2014

They're not intuitive, but they're standard for install.packages

@hadley hadley closed this in 6ac88ef Mar 18, 2014

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.