Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_github doesn't properly install from pull requests #405

Closed
wch opened this issue Dec 20, 2013 · 2 comments
Closed

install_github doesn't properly install from pull requests #405

wch opened this issue Dec 20, 2013 · 2 comments

Comments

@wch
Copy link
Member

@wch wch commented Dec 20, 2013

There seem to be two different bugs here. Examples:

Using the pull= argument:

> devtools::install_github('rstudio/shiny', pull=342, ref=NULL)
Error: client error: (403) Forbidden

Using the user/repo#pull syntax:

> install_github('rstudio/shiny#342')
Error in FUN("rstudio/shiny#342"[[1L]], ...) : 
  Must specify either a ref or a pull request, not both. Perhaps you want to use 'ref=NULL'?
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 20, 2013

The first issue seems to be a temporary one, I can install using your command. The second issue has been fixed (but not yet merged) in #390.

Also related: #388 (where the second issue has been reported first).

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 10, 2014

I can now replicate the first issue in a "clean" environment (from packrat), not sure why it does not occur in my "regular" environment. Can be fixed by passing

, config = add_headers("User-agent" = "hadley/devtools")

to the GET call in github_pull_info. I'm about to submit a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants