Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools:::email fails under RStudio on macosx #433

Closed
jefferis opened this Issue Mar 11, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@jefferis
Copy link

jefferis commented Mar 11, 2014

The email() function called by release() fails silently under Rstudio on mac. This happens because

# regular R mac gui
> options('browser')
$browser
[1] "/usr/bin/open"
# rstudio
> options('browser')
$browser
function (url) 
{
    .Call("rs_browseURL", url)
}
<environment: 0x1020ca470>

I guess one possible fix would be to temporarily override the browser option inside email() with "/usr/bin/open" on mac.

https://github.com/hadley/devtools/blob/21cc4a6689bce3531daa3e295cf676a035af769c/R/release.r#L148-L159

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 11, 2014

@jjallaire is there a way to find out the default value of getOption("browser") before it's overridden by Rstudio?

@jjallaire

This comment has been minimized.

Copy link
Collaborator

jjallaire commented Mar 11, 2014

No there isn't currently a way to do this. You could just take the default
for each platform as observed in a vanilla version of R (it's highly
doubtful that users are overriding "browser" and even if they are email
from devtools is such as specialized case that using the base R default
isn't likely to be objectionable)

On Tue, Mar 11, 2014 at 10:43 AM, Hadley Wickham
notifications@github.comwrote:

@jjallaire https://github.com/jjallaire is there a way to find out the
default value of getOption("browser") before it's overridden by Rstudio?

Reply to this email directly or view it on GitHubhttps://github.com//issues/433#issuecomment-37303019
.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 14, 2014

@jjallaire not high priority, but could rstudio learn to pass through unrecognised url schemes?

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Mar 17, 2014

Same on Ubuntu.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 17, 2014

And it looks like it's NULL on windows

@hadley hadley closed this in a45e87c Mar 18, 2014

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.