Show size of uploaded archive before submission in release()

[krlmlr]

This just hit me -- some test artifacts were ignored in .gitignore but not in .Rbuildignore and unnecessarily increased the file size by a large factor.

Perhaps a listing of the directories, too?

(On the other hand, you can always rerun release() without clicking on the confirmation link, that arrives by e-mail, so this is probably of minor importance.)

[gaborcsardi]

Don't you get warnings/notes for these from check()?

[krlmlr]

I do get warnings if the vignette is too large and can be compressed. I didn't notice any warnings about a substantially larger size of the archive.

[hadley]

I would have thought existing warnings would have picked this up too. But displaying the archive size prior to the upload question would work well

[hadley]

It'd be useful if could give me the output of git clean -n in order to help me understand when this problem occurs

[krlmlr]

In this case, git clean -nx would have shown lots of stuff in the tests directory -- ignored via .gitignore but forgot to ignore via .Rbuildignore. (git clean -n would have been empty, -x = "also clean ignored files".)

[wch]

I think you also need -d, as in git clean -nxd so that if there are any subdirs, they'll be listed as well.

For example:

$ git clean -n
Would remove shiny.sublime-project
Would remove test.R

$ git clean -nx
Would remove .Rhistory
Would remove shiny.sublime-project
Would remove test.R

$ git clean -nxd
Would remove .Rhistory
Would remove .Rproj.user/
Would remove shiny.sublime-project
Would skip repository temp/progress
Would remove temp/app
Would remove test.R
Would remove tools/node_modules/

[hadley]

I'd be happy to review a PR that printed the file size before uploading

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/