New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show size of uploaded archive before submission in release() #683

Closed
krlmlr opened this Issue Jan 7, 2015 · 8 comments

Comments

Projects
None yet
4 participants
@krlmlr
Member

krlmlr commented Jan 7, 2015

This just hit me -- some test artifacts were ignored in .gitignore but not in .Rbuildignore and unnecessarily increased the file size by a large factor.

Perhaps a listing of the directories, too?

(On the other hand, you can always rerun release() without clicking on the confirmation link, that arrives by e-mail, so this is probably of minor importance.)

@gaborcsardi

This comment has been minimized.

Member

gaborcsardi commented Jan 7, 2015

Don't you get warnings/notes for these from check()?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 7, 2015

I do get warnings if the vignette is too large and can be compressed. I didn't notice any warnings about a substantially larger size of the archive.

@hadley

This comment has been minimized.

Member

hadley commented Jan 7, 2015

I would have thought existing warnings would have picked this up too. But displaying the archive size prior to the upload question would work well

@hadley

This comment has been minimized.

Member

hadley commented Jan 9, 2015

It'd be useful if could give me the output of git clean -n in order to help me understand when this problem occurs

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 9, 2015

In this case, git clean -nx would have shown lots of stuff in the tests directory -- ignored via .gitignore but forgot to ignore via .Rbuildignore. (git clean -n would have been empty, -x = "also clean ignored files".)

@wch

This comment has been minimized.

Member

wch commented Jan 9, 2015

I think you also need -d, as in git clean -nxd so that if there are any subdirs, they'll be listed as well.

For example:

$ git clean -n
Would remove shiny.sublime-project
Would remove test.R

$ git clean -nx
Would remove .Rhistory
Would remove shiny.sublime-project
Would remove test.R

$ git clean -nxd
Would remove .Rhistory
Would remove .Rproj.user/
Would remove shiny.sublime-project
Would skip repository temp/progress
Would remove temp/app
Would remove test.R
Would remove tools/node_modules/
@hadley

This comment has been minimized.

Member

hadley commented Apr 21, 2015

I'd be happy to review a PR that printed the file size before uploading

@hadley hadley closed this Apr 21, 2015

hadley added a commit that referenced this issue Apr 23, 2015

Merge pull request #768 from krlmlr/683-release-size
Show file size before submitting to CRAN. Fixes #683
@lock

This comment has been minimized.

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.