New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_vignette fails quietly if no knitr available #736

Closed
barryrowlingson opened this Issue Mar 10, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@barryrowlingson

barryrowlingson commented Mar 10, 2015

I have a package with a knitr-built .Rnw vignette, pulled it to a new machine with the latest R and devtools. Build the vignette:

 > build_vignettes("./colloc/")
 NULL

Nothing happens. Hmm. Try command line:

 Error in loadVignetteBuilder(pkgdir, TRUE) : 
   vignette builder 'knitr' not found

Installing knitr fixes the build_vignettes call.

Could build_vignettes produce an informative message as R CMD build does?

@hadley

This comment has been minimized.

Member

hadley commented Apr 28, 2015

I just call tools::buildVignettes() so I'm a bit mystified as to why it doesn't complain.

What do you think about automatically installing the vignette builder package if needed?

@hadley hadley closed this in d2bdbad Apr 30, 2015

@lock

This comment has been minimized.

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.