Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept alternative maintainer email for build_win #800

Closed
maxheld83 opened this issue May 14, 2015 · 5 comments
Closed

accept alternative maintainer email for build_win #800

maxheld83 opened this issue May 14, 2015 · 5 comments

Comments

@maxheld83
Copy link
Member

@maxheld83 maxheld83 commented May 14, 2015

I'm guessing this is a common scenario:

  1. I'm working on a fork of some maintainer's R project
  2. I'm ready to open a PR and want to make sure that it passes R CMD Check on all platforms ...
  3. ... so I use the great build_win
  4. ... and realize a couple of seconds too late that the resulting email will be sent to the maintainer of the project.

Would be nice to specify an alternative email address to build_win as an argument.

@wch
Copy link
Member

@wch wch commented May 14, 2015

Win-builder simply uses the maintainer's email address, so this would require modification to the DESCRIPTION file before uploading.

I do agree that in general that something like this would be useful - perhaps a confirmation prompt that says "message will be sent to person@foo.com", before uploading the package?

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 9, 2015

We could use as.person(eval(parse(text=getOption("devtools.desc.author"))))$email as e-mail address, and perhaps a prompt (in interactive mode) or an argument that allows overriding the maintainer's mail address (for scripting). Not sure if this will make everybody happy, though.

@hadley
Copy link
Member

@hadley hadley commented Jun 19, 2015

I think it would be fine as an argument to build_win(). But modifying the DESCRIPTION file is a pain.

@hadley
Copy link
Member

@hadley hadley commented Sep 2, 2015

I'd be happy to accept a PR that implemented this.

@lock
Copy link

@lock lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants