Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for vignettes titled "Vignette Title" #960

Closed
jennybc opened this issue Oct 28, 2015 · 4 comments
Closed

Check for vignettes titled "Vignette Title" #960

jennybc opened this issue Oct 28, 2015 · 4 comments
Milestone
1.10

Comments

@jennybc
Copy link
Member

jennybc commented Oct 28, 2015

I keep coming across vignettes entitled "Vignette Title". Here are some of the ones currently on CRAN:

https://github.com/search?l=rmarkdown&q=%22Vignette+Title%22+user%3Acran&ref=searchresults&type=Code&utf8=✓

This might be nice to catch in a doctor function or release()?
@hadley
Copy link
Member

hadley commented Jan 12, 2016

Yes!

@hadley
Copy link
Member

hadley commented Jan 20, 2016

Any interest in doing a PR for this? I think you could just do a regexp on the first (say) ~20 lines. It would be another function called from release_checks()

@jennybc
Copy link
Member Author

jennybc commented Jan 20, 2016

OK yes.

@hadley hadley modified the milestone: 1.10 Jan 20, 2016
@hadley hadley closed this as completed in 9ea1257 Jan 22, 2016
hadley added a commit that referenced this issue Jan 22, 2016
@hadley
Merge pull request #1043 from jennybc/check-vignette-titles
ab0684b 
flag vignettes entitled "Vignette Title"; closes #960
@lock
Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@hadley @jennybc