New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle repositories specified in Additional_repositories #1028

Merged
merged 2 commits into from Jan 16, 2016

Conversation

Projects
None yet
2 participants
@jimhester
Member

jimhester commented Jan 15, 2016

This seems to be all that is needed (assuming what is in Additional_repositories points to a proper 'CRAN-like' repository.

An example repository is https://github.com/rOpenGov/bibliographica, which has dependencies gender and genderData from ropensci, the rest from CRAN.

Fixes #907

@hadley

This comment has been minimized.

Member

hadley commented Jan 15, 2016

Cool! Could you please also add a bullet to NEWS?

@jimhester

This comment has been minimized.

Member

jimhester commented Jan 15, 2016

I am going to add the fix for #943 here as well as they are somewhat related and this pull request will exacerbate the situation there (as users will have more than one repo more often).

@jimhester

This comment has been minimized.

Member

jimhester commented Jan 15, 2016

Ok I decided to make them separate after all, this one looks good to merge now.

@hadley hadley merged commit e1e40ce into r-lib:master Jan 16, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jan 16, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment