New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "http://" type Github hosts, not only "https://" #1131

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ampu3ro

ampu3ro commented Mar 25, 2016

My company has an enterprise account with root endpoint http://github.bdap.enernoc.com/api/v3 for the API. I would imagine some others have hosts like this as well. In fact, Github's manual refers to endpoints as http(s)://.

The minor tweak in the PR defaults to https: if not specified in the host argument, otherwise allowing something like

install_github("me/myrepo",host="http://github.bdap.enernoc.com/api/v3")

to work. Hope it helps!

Nico added some commits Mar 25, 2016

Nico
Nico
Revert "remove "http://" comments"
This reverts commit d3fa693.
@ampu3ro

This comment has been minimized.

ampu3ro commented Apr 7, 2016

PTAL. Sorry about the unnecessary commenting :/ first time

@jimhester

This comment has been minimized.

Member

jimhester commented Apr 7, 2016

This PR breaks the tests on linux and windows. I would suggest running the tests locally with devtools::test() and figuring out why this change breaks them, then update your code so it no longer does so.

@ampu3ro

This comment has been minimized.

ampu3ro commented Apr 8, 2016

Can't say it was easy (rtools is super finicky!), but I think I got all the tests to pass. Not sure what's failing in the AppVeyor tests though...

@hadley hadley added this to the 1.12.0 milestone Jun 2, 2016

@hadley hadley closed this in d802383 Jun 3, 2016

@ampu3ro

This comment has been minimized.

ampu3ro commented Jun 3, 2016

much better solution. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment